fix(app): composer approval control + settings cleanups - #49
Merged
Conversation
Four settings/composer UX fixes.
1. Share URL i18n: the Sharing section (section title + shareUrl
title/description/placeholder) was English-only, so it showed
untranslated. Added zh + zht translations, and backfilled all 15
non-English locales so the settings-key parity test passes (it was
already red on these keys + the earlier expertPanelDefault keys).
2. Approval control moved to the composer: removed the auto-accept row
from settings and added an ApprovalControl next to the build/plan
agent selector, modeled on Codex's approval selector — a two-option
picker ("Request approval" default, "Auto-approve" when armed) whose
button label reflects the current mode. Directory-scoped, backed by
the existing permission context (isAutoAcceptingDirectory /
toggleAutoAcceptDirectory).
3. Servers tab: the duplicate "Add server" + "Connect to server" buttons
are merged into one "Add server" menu with two items (Add HTTP server
/ Connect to server), matching the single-entry status popover.
4. Import: the run button is now a full-width bar button under the
options (with Cancel beside it while running) instead of a small
right-aligned row control.
Tests: i18n parity green; settings-UX test updated to assert the
approval control moved to the composer. App suite 540 pass, typecheck
clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
lxrzlyr
pushed a commit
that referenced
this pull request
Jul 10, 2026
Four settings/composer UX fixes, rebased cleanly onto the latest `dev` (supersedes #47, whose first 5 commits already landed via #46). ## Changes 1. **Share URL i18n** — the Sharing settings section was English-only; added zh + zht translations and backfilled all 15 non-English locales so the settings-key parity test passes. 2. **Approval control → composer** — removed the auto-accept row from settings; added an `ApprovalControl` next to the build/plan agent selector (Codex-style two-option picker: "Request approval" default / "Auto-approve"), directory-scoped, backed by the existing permission context. 3. **Servers tab** — merged the duplicate "Add server" + "Connect to server" buttons into one "Add server" menu with two items. 4. **Import** — the run button is now a full-width bar button under the options (Cancel beside it while running). ## Verification - App suite: 540 pass - i18n parity: green - Typecheck: clean (15/15 tasks in pre-push) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: deepagent-ai <jamessmithm539@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four settings/composer UX fixes, rebased cleanly onto the latest
dev(supersedes #47, whose first 5 commits already landed via #46).Changes
ApprovalControlnext to the build/plan agent selector (Codex-style two-option picker: "Request approval" default / "Auto-approve"), directory-scoped, backed by the existing permission context.Verification
🤖 Generated with Claude Code